Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(greptiemdb_logs source): add config for greptimedb_logs to add http header #22651

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

paomian
Copy link
Contributor

@paomian paomian commented Mar 13, 2025

Summary

  • add http header config for greptimedb_logs sink

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: external docs Anything related to Vector's external, public documentation labels Mar 13, 2025
@paomian paomian marked this pull request as ready for review March 17, 2025 16:41
@paomian paomian requested review from a team as code owners March 17, 2025 16:41
@paomian paomian force-pushed the chore/greptimedb_header branch from aff1a8a to a181fc7 Compare March 17, 2025 16:48
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paomian

@pront pront self-assigned this Mar 24, 2025
@paomian paomian requested a review from pront March 26, 2025 05:06
@paomian
Copy link
Contributor Author

paomian commented Apr 1, 2025

@pront Thanks to review. Is there anything else to improve about this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants