enhancement(throttle transform): Refactor throttle/rate limiter logic into reusable wrapper #22719
+224
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: transforms
ArunPiduguDD
force-pushed
the
refactor-throttle-transform
branch
from
85022b1 to
909e54c
Compare
ArunPiduguDD
changed the title
ArunPiduguDD
force-pushed
the
refactor-throttle-transform
branch
from
909e54c to
9e17937
Compare
ArunPiduguDD
changed the title
…reusable wrappers
ArunPiduguDD
force-pushed
the
refactor-throttle-transform
branch
from
9e17937 to
6495dd4
Compare
ArunPiduguDD
added
the
no-changelog
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.49s Total Time |
pront
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Thanks @ArunPiduguDD, the transform is much more readable now.
src/transforms/throttle/transform.rs
Outdated
| } | ||
|
|
||
| impl<C, I> TaskTransform<Event> for Throttle<C, I> | ||
| where | ||
| C: clock::Clock<Instant = I> + Send + 'static + Clone, | ||
| C: clock::Clock<Instant = I> + Send + Sync + 'static + Clone, |
There was a problem hiding this comment.
Yea it's required when spawning the key flush thread for the rate-limiter
ArunPiduguDD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to re-use pieces of the
throttleprocessor implementation, in particular the rate-limiter logic. Refactors out constructing / running the rate limiter (mainly by running I mean periodically flushing old keys) into a separate struct that can be re-used elsewhere. Also refactors out some metrics related code, and moves thethrottleimplementation inside it's own folder intransforms(further splitthrottle.rsinto 2 files,config.rsandtransform.rsto mimic the file structure seen in other transform implementations such assample,dedupe, etc.)Change Type
Is this a breaking change?
How did you test this PR?
Tested with vector config/pipeline containing throttle processor
Does this PR include user facing changes?
Checklist
make check-allis a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo nextest run --workspace(alternatively, you can runcargo test --all)Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References