Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
windows-rs
to the latest 0.51 version.There are some new patterns to deal with optional out params that
windows
isn't handling in a very elegant way, e.g. options of options of mutable pointers where the difference betweenNone
andSome(null_mut())
is not particularly evident, so some helper functions to deal with these cases should be added and applied:out_param
for pre-allocated out parameterstry_out_param
for pre-allocated out parameters in a fallible functionout_ptr
for out pointers allocated by the function itselftry_out_ptr
for out pointers allocated by a fallible functionExample of usage:
Blocked by #126