Make UnregisterClassW not panic #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this solves it, no more crashes. Logs are just standard debug ones, messy as it's wine with broken colors so I'll exclude them unless they're really needed. |
|
Messy logs are fine actually! I can clean them up easily but I want to see what error is reported. I'll merge the PR as soon as I manage to carve some time, it's been a hectic week. |
veeenu
force-pushed
the
unregister-deez
branch
from
3314bc2 to
119b85f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132
@vars1ty could you please give this branch a spin before I merge it in? If you could please also pipe the logs somewhere and post them that'd be awesome.
I couldn't run the program just yet because I'm setting up a VM. I'd prefer not to run foreign software on my host machine. I can