-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace texture image data #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a scary swole doge if I've ever seen one. 😅
Style looks good to me in general, please allow me a bit of time so I can review it properly but it's going in the right direction.
This will probably warrant a breaking semver minor bump to 0.7 since the public API is getting changed.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great! Works fine on Wine too.
I have just a couple observations/nits for style, and one important request for compat.
Note: After this gets merged in, we'll have to bump to 0.7.0
due to breaking changes and update hudbook
accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you so much 🙌
I've been trying to implement similar functionality from inside the renderloop (I am passing the swapchain to it), using hudhook 0.4(?), and only managed to do so for OpenGL so far. DX9 crashes no matter what, DX11 displays random white symbols (what?) and DX12 is not tested. I'm not entirely sure if it is even possible without modifying the hudhook code. From what I can tell, the current functionality on hudhook 0.8 only allows the upload of textures from the initializing stage. Is this correct? Edit; I've dived into the code a little bit now. Clearly, DX9, DX11 and DX12 completely lacked this functionality before, hence why I can't implement it. I'll probably have to take the plunge, bump up and try to transfer my much needed modifications to my own repo. I noticed the the |
|
Fixes #147.
"Allow edits by maintainers" is on. If you have any suggestions for improvement, just push changes to this branch, specially about naming and code repetition.