Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: healthcheck for aws ALB #33

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

tim-goto
Copy link
Contributor

@tim-goto tim-goto commented Oct 14, 2024

Pull Request

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Build related changes
  • Documentation content changes
  • Other: (describe here)

Proposed Change

AWS ALBs require a healthcheck endpoint so the target group reports back healthy.

Breaking Change?

  • Yes
  • No

Checklist

Please validate that your PR fulfills the following requirements:

  • I have read the CONTRIBUTING.md documentation (if available)
  • I have branched from the default repo branch (can be master, main, or release/vX.X)
  • I have checked that a similar PR does not exist or has been rejected in the past
  • PR changes are specific to a feature or bug
  • No style/format/cosmetic changes included
  • I have used existing style and naming patterns in my changes
  • Tests for the changes have been added/updated (if relevant)
  • Built/compiled and tested locally
  • Docs have been added/updated (if relevant)
  • I have squashed my changes into a single commit

Additional Information

@NorseGaud NorseGaud self-requested a review October 14, 2024 13:12
@NorseGaud NorseGaud self-assigned this Oct 14, 2024
@NorseGaud NorseGaud merged commit e0f8c4f into veertuinc:main Oct 14, 2024
2 checks passed
@tim-goto tim-goto deleted the feature/tharing/healthcheck branch December 3, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants