-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep params in path overlay normalizer at the higher level #9258
base: main
Are you sure you want to change the base?
Conversation
The ci should have taken care of examples that are in the repo already. The question is whether the params should be in the first layer rather than at the outer spec level. The code looked intentional so I wanted to have someone else check. |
I think a good check is whether a deeply nested spec breaks with this change. And test selection params. I should do those. |
The intention of this PR is not exactly clear, but is the following issue + comment related here? #8230 (comment) Also, when is this code invoked? I think this param lifting could be done in the section creating the extended vega-lite code. |
Previously we moved the params into the layer but it seems like we should keep it at the higher level.
This fixes an issue that surfaced in #9253.