Skip to content

Commit

Permalink
Flag s3 tests behind VEGAFUSION_S3_TESTS environment variable
Browse files Browse the repository at this point in the history
  • Loading branch information
jonmmease committed Nov 13, 2023
1 parent 993d9a8 commit 1d86632
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions pixi.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ test-py-jupyter-headless = { cmd = "export VEGAFUSION_TEST_HEADLESS=1 && cd pyth
build-vegajs-runtime = { cmd = "cd vegafusion-runtime/tests/util/vegajs_runtime && npm install" }
test-rs-core = "cargo test -p vegafusion-core $0"
test-rs-runtime = { cmd="cargo test -p vegafusion-runtime $0", depends_on = ["build-vegajs-runtime"] }
test-rs-runtime-s3 = { cmd="VEGAFUSION_S3_TESTS=1 cargo test -p vegafusion-runtime $0", depends_on = ["build-vegajs-runtime"] }
test-rs-server = "cargo test -p vegafusion-server $0"
test-rs-sql = "cargo test -p vegafusion-sql $0"
test-rs = { cmd = "cargo test --workspace --exclude vegafusion-python-embed --exclude vegafusion-wasm $0", depends_on = ["build-vegajs-runtime"] }
Expand Down
6 changes: 6 additions & 0 deletions vegafusion-runtime/tests/test_pre_transform_values.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ mod tests {
use crate::{crate_dir, setup_s3_environment_vars};
use serde_json::json;
use std::collections::HashMap;
use std::env;
use std::fs;
use std::sync::Arc;
use vegafusion_common::data::table::VegaFusionTable;
Expand Down Expand Up @@ -355,6 +356,11 @@ mod tests {

#[tokio::test]
async fn test_pre_transform_dataset_s3() {
let run_s3_tests = env::var("VEGAFUSION_S3_TESTS").is_ok();
if !run_s3_tests {
return;
}

// Note: s3 tests require the pixi start-minio job
setup_s3_environment_vars();

Expand Down

0 comments on commit 1d86632

Please sign in to comment.