bin and timeunit can be lifted out of facets as well

vega · Jan 30, 2024 · 31acb0a · 31acb0a
1 parent 3923bdb
commit 31acb0a
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/vegafusion-core/src/planning/lift_facet_aggregations.rs b/vegafusion-core/src/planning/lift_facet_aggregations.rs
@@ -136,6 +136,14 @@ impl MutChartVisitor for ExtractFacetAggregationsVisitor {
                     lifted_transforms.push(TransformSpec::Filter(tx));
                     child_dataset.transform.remove(0);
                 }
+                Some(TransformSpec::Bin(tx)) => {
+                    lifted_transforms.push(TransformSpec::Bin(tx));
+                    child_dataset.transform.remove(0);
+                }
+                Some(TransformSpec::Timeunit(tx)) => {
+                    lifted_transforms.push(TransformSpec::Timeunit(tx));
+                    child_dataset.transform.remove(0);
+                }
                 _ => {
                     // Reached unsupported transform type without an aggregation
                     break None;