Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in bin transform with empty input table #395

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jonmmease
Copy link
Collaborator

When a transform pipeline that involves extent and bin was fed an empty table as input, the following error would occur.

Internal error: Cannot convert NULL to f64

The issue is that extent returns [NULL, NULL] in this case (which is valid) and bin would attempt to cast these elements to f64 values (which is not valid). Now we default to [0.0, 0.0] in this case (any valid values would work since the result will be an empty table).

@jonmmease jonmmease merged commit e4f8370 into main Sep 25, 2023
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant