Fix patch_pre_transformed_spec when object is replaced by an array #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the patch pre-transformed spec logic, when a JSON object is replaced by an array, it could sometimes happen that the result would be an object with integer keys (e.g.
{"0": "A", "1": "BB"}
instead of an array (e.g.["A", "BB"]
). I think this is a natural consequence of how JSON patching works, so I don't think it's necessarily a bug in json-patch.This PR identifies such objects and converts them to proper arrays.