Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore pyarrow 10 support #443

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Restore pyarrow 10 support #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c318f2
restore pyarrow 10 support
jonmmease Jan 9, 2024
229ac80
pin altair to 5.1.2 in pyarrow 10 test
jonmmease Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,8 @@ jobs:
ls -la
python -m pip install vegafusion-*.whl
python -m pip install vegafusion_python_embed-*macosx_10_7_x86_64.whl
python -m pip install pytest vega-datasets polars duckdb altair vl-convert-python scikit-image pandas==2.0
python -m pip install pytest vega-datasets polars duckdb vl-convert-python scikit-image pandas==2.0
python -m pip install pyarrow==10.0 altair==5.1.2
- name: Test vegafusion
working-directory: python/vegafusion/
run: pytest
Expand Down
2 changes: 1 addition & 1 deletion python/vegafusion/vegafusion/datasource/dfi_datasource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from typing import Iterable
import re
import pyarrow as pa
from pyarrow.interchange import from_dataframe

from typing import Any, Dict
from ._dfi_types import DtypeKind, DataFrame as DfiDataFrame
Expand Down Expand Up @@ -79,6 +78,7 @@ def schema(self) -> pa.Schema:
return self._schema

def fetch(self, columns: Iterable[str]) -> pa.Table:
from pyarrow.interchange import from_dataframe
columns = list(columns)
projected_schema = pa.schema([f for f in self._schema if f.name in columns])
table = from_dataframe(self._dataframe.select_columns_by_name(columns))
Expand Down
Loading