-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to DataFusion 36 #457
Conversation
VegaFusion tests are passing now. There are a couple of CI issues:
Prior to this PR, we were on ring 0.16.20. Oh, this looks directly relevant: briansmith/ring#1728. We may need to bump manylinux past 2014. |
This reverts commit d474eb2.
DataFusion doesn't know how to simplify it yet, which breaks our scalar value evaluation.
Legal Risk AGPL-3.0 |
Legal Risk MPL-2.0 |
Legal Risk AGPL-3.0 |
Legal Risk AGPL-3.0 |
Legal Risk AGPL-3.0 |
This was only used in testing (not part of the production build), but to simplify things I switch to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this UDF in favor of the built-in DataFusion make_list
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this UDF in favor of DataFusion's built-in array_length and character_length functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with DataFusion's built-in isnan function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to drop our custom span UDF in favor of DataFusion transforms. I think I got it working, but DataFusion didn't seem to be able to simplify array expressions, which is what we use for scalar evaluation.
This ended up being a fairly large PR to update DataFusion to version 36.0.0 and arrow-rs to version 50.0.0. We're updating from version 32.0.0, and a lot has changed!