Move prost codegen to outdir #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
commented
Nov 15, 2024
| @@ -435,9 +435,7 @@ impl VegaFusionTable { | |||
| } | |||
|
|
|||
| pub fn get_hash(&self) -> u64 { | |||
| let mut hasher = RandomState::with_seed(123).build_hasher(); | |||
| self.hash(&mut hasher); | |||
| hasher.finish() | |||
There was a problem hiding this comment.
also ran clippy --fix
jonmmease
added a commit
that referenced
this pull request
Nov 16, 2024
* move prost gen to default out dir location * clippy fix * fmt * remove --no-verify * fix warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the prost codegen to locate the generated files in the output directory rather than in the src tree. This should eliminate the docs.rs failure due to the src dir being written to by build.rs