-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data node v2 spec #763
Data node v2 spec #763
Conversation
Need to add the FE team requirements: https://www.notion.so/vegaprotocol/Core-API-design-ideas-data-node-Requirements-e8d00fbd0c96425687bfa0bc00baf8eb#915a0966aec742eba64aaa0125816c8e |
@campbellssource - please can you review this and add the FE requirements to this as its part of Oregon Trail |
@pscott31 and @Vegaklaus - to discuss the db choice and how this can work with hashing and update spec requirements if needed |
non-protocol-specs/0000-data-node.md
Outdated
|
||
### Orders | ||
|
||
Store the orders at the configured resolution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it part of this spec to think about how the data is to be retrieved retrieved as well? Perhaps that's a separate thing to think about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things that we have talked about at various points which aren't in here; such as proof of storage, bootstrapping another node without playing the whole chain etc.. Again maybe they are topics for another day or another spec. Something else to consider is what behaviour to expect when there is restore from a checkpoint (delete everything?) or a snapshot (delete everything with a block height > the snapshot and continue?)
Results: The database will be designed so it can (deterministically) map a random number into a table, and then (also deterministically) be able to go sequentially through the contents of this table (e.g., by timestamp) starting at a point determined by another random number. @pscott31 does that sum it up correctly ? |
Yeah, that's about it Klaus :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two questions for clarification.
The data node v2 must support the following workflow:
|
@gordsport forgive this PR into a PR #886 |
If we get this working vegaprotocol/quant#22 then there may be a way of using the |
Added some general FE requirements. We may need to work out a process specing the specific `augmentations` to APIs or additional server side calculators in a way that isn't making this spec bigger.
Hi @jeremyletang @pscott31 If you are OK with the naming please can you give it a review and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed in protocol design meeting this can be merged
No description provided.