Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate teams into market-sim #520

Merged
merged 9 commits into from
Oct 7, 2023
Merged

feat: integrate teams into market-sim #520

merged 9 commits into from
Oct 7, 2023

Conversation

cdummett
Copy link
Collaborator

@cdummett cdummett commented Oct 5, 2023

Description

PR integrates APIs to cover referral sets and teams.

The fuzzing test now passes the relevant fields to create a team from the referral set.

Testing

  • Tests added for new APIs.
  • Tests added to check the coverage of vega APIs - tests are marked as api tests which are not run as part of integration tests.

To check coverage

make test_api

Breaking Changes

None

Closes

None

@cdummett cdummett added the enhancement New feature or request label Oct 5, 2023
@cdummett cdummett added this to the ☄️ Cosmic Elevator milestone Oct 5, 2023
@cdummett cdummett self-assigned this Oct 5, 2023
@cdummett cdummett marked this pull request as ready for review October 6, 2023 09:10
@cdummett cdummett requested a review from a team as a code owner October 6, 2023 09:10
vega_sim/api/data.py Outdated Show resolved Hide resolved
vega_sim/api/data.py Show resolved Hide resolved
vega_sim/api/trading.py Show resolved Hide resolved
@TomMcL
Copy link
Contributor

TomMcL commented Oct 6, 2023

I'm not entirely sure on the value of the api tests given that I'm not sure covering every proto etc is an end goal, but they don't hurt so let's add them in!

@cdummett cdummett requested a review from TomMcL October 6, 2023 12:09
@cdummett cdummett merged commit 14d715b into develop Oct 7, 2023
6 checks passed
@cdummett cdummett deleted the feat/teams branch October 7, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants