feat: integrate stop orders into market-sim #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/stop_orders
branch
from
af50b03 to
5ecb9df
Compare
cdummett
force-pushed
the
feat/stop_orders
branch
from
5ecb9df to
dc7bc78
Compare
cdummett
force-pushed
the
feat/stop_orders
branch
from
dc7bc78 to
61bb8bb
Compare
cdummett
force-pushed
the
feat/stop_orders
branch
from
9915c7d to
adb6284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR implements stop orders into market-sim and the fuzzing test.
Moves towards an approach where the service layer has multiple "build" methods which can build vega protos for submitting transactions.
In a future PR this can be applied to existing commands and tidied up into it's own module which the service layer can access through compartmentalisation. Basic service layer methods for doing 'frequent' commands like submit order or submit liquidity will still exist. More complicated orders like a pegged iceberg order will not be supported on the service layer.
Approach prevents a cluttered service layer with methods with 30+ fields.
Testing
Currently failing fuzz test - blocked by vegaprotocol/vega#9811
Breaking Changes
createmethods renamed tobuildbuild_pegged_orderto service layer in preparation to be moved to new module