Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new spam test #523

Closed
wants to merge 32 commits into from
Closed

feat: new spam test #523

wants to merge 32 commits into from

Conversation

Sohill-Patel
Copy link

@Sohill-Patel Sohill-Patel commented Oct 10, 2023

@Sohill-Patel Sohill-Patel self-assigned this Oct 10, 2023
Copy link
Contributor

@davidsiska-vega davidsiska-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we accept that null chain is enough to test spam:
The actual system test, testing the AC should live in the system test repo. So in the system test repo you can import the market sim package, run the tests you want on top of market sim / null chain.

This ensures that
a) the test is run as mandatory on PRs / included in overnight runs (as you set it)
b) market sim codebase is kept for it's purpose - which is market simulations.

@Sohill-Patel Sohill-Patel marked this pull request as ready for review October 13, 2023 14:23
@Sohill-Patel Sohill-Patel requested a review from a team as a code owner October 13, 2023 14:23
@Sohill-Patel
Copy link
Author

{"vega":"develop"}

Copy link
Collaborator

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments - the tests and mods to the service classes look good though.

Just need to address Davids comments as the tests themselves might need to be moved to system-tests.

.env Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
@Sohill-Patel Sohill-Patel changed the title feat: new spam test in progress feat: new spam test Oct 16, 2023
@Sohill-Patel
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants