-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new spam test #523
feat: new spam test #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we accept that null chain is enough to test spam:
The actual system test, testing the AC should live in the system test repo. So in the system test repo you can import the market sim package, run the tests you want on top of market sim / null chain.
This ensures that
a) the test is run as mandatory on PRs / included in overnight runs (as you set it)
b) market sim codebase is kept for it's purpose - which is market simulations.
d933da1
to
c64f833
Compare
9a2c8f9
to
ddcc880
Compare
This reverts commit 6a0bafb.
ddcc880
to
24600ea
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments - the tests and mods to the service classes look good though.
Just need to address Davids comments as the tests themselves might need to be moved to system-tests.
Description
Spam test for AC
Testing
Breaking Changes
Closes
close https://github.com/vegaprotocol/OctoberACs/issues/390
close https://github.com/vegaprotocol/OctoberACs/issues/392
close https://github.com/vegaprotocol/OctoberACs/issues/394