Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding functionality to update market states #530

Merged
merged 3 commits into from
Oct 18, 2023
Merged

feat: Adding functionality to update market states #530

merged 3 commits into from
Oct 18, 2023

Conversation

TomMcL
Copy link
Contributor

@TomMcL TomMcL commented Oct 18, 2023

Description

Adding calls to service for the functionality to change market state through governance

Testing

Manually tested, state updates. Added integration test

Breaking Changes

None

Closes

@TomMcL TomMcL self-assigned this Oct 18, 2023
@TomMcL TomMcL requested a review from a team as a code owner October 18, 2023 10:46
cdummett
cdummett requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - two small comments and I think the protos are out of date.

vega_sim/service.py Outdated Show resolved Hide resolved
vega_sim/service.py Outdated Show resolved Hide resolved
@TomMcL TomMcL requested a review from cdummett October 18, 2023 11:39
@TomMcL TomMcL enabled auto-merge (squash) October 18, 2023 12:10
@TomMcL TomMcL merged commit 73103c8 into develop Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdummett cdummett cdummett approved these changes

Assignees

@TomMcL TomMcL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomMcL @cdummett