feat: implement disposalSlippageRange into vega-market-sim #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cdummett
force-pushed
the
feat/sla-slippage-range
branch
from
cc8c4f0 to
a129527
Compare
cdummett
force-pushed
the
feat/sla-slippage-range
branch
from
a129527 to
7bd6f48
Compare
TomMcL
previously approved these changes
Apr 18, 2024
TomMcL
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
disposalSlippageRangeto proposals to fix failing runs.Initial mainnet runs shows sensible liquidation behaviour.