Skip to content

Commit

Permalink
Merge pull request #10339 from vegaprotocol/fix-10327
Browse files Browse the repository at this point in the history
Fix GraphQL batch proposals
  • Loading branch information
jeremyletang authored Jan 10, 2024
2 parents 1a8b108 + a149752 commit 10249f6
Show file tree
Hide file tree
Showing 12 changed files with 1,959 additions and 97 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,10 @@
- [10321](https://github.com/vegaprotocol/vega/issues/10321) - Fix `ListPartyMarginModes` panic.
- [10324](https://github.com/vegaprotocol/vega/issues/10324) - Fix `GetMarketHistoryByID` to only return the most recent market data information when no dates are provided.
- [10318](https://github.com/vegaprotocol/vega/issues/10318) - Prevent stop orders being placed during opening auction.
- [476](https://github.com/vegaprotocol/core-test-coverage/issues/476) - Add tests for markets expiring in opening auction, fix a bug for future markets.
- [476](https://github.com/vegaprotocol/core-test-coverage/issues/476) - Add tests for markets expiring in opening auction, fix a bug for future markets.
- [10354](https://github.com/vegaprotocol/vega/issues/10354) - Renumbered SQL migration scripts 0055-0067 due to 0068 being released as part of a patch without renumbering.
- [476](https://github.com/vegaprotocol/core-test-coverage/issues/476) - Add tests for markets expiring in opening auction, fix a bug for future markets.
- [10339](https://github.com/vegaprotocol/vega/issues/10339) - Fix for GraphQL batch proposals support.

## 0.73.0

Expand Down
4 changes: 4 additions & 0 deletions datanode/api/trading_data_v2.go
Original file line number Diff line number Diff line change
Expand Up @@ -2309,6 +2309,10 @@ func (t *TradingDataServiceV2) ListGovernanceData(ctx context.Context, req *v2.L
if err != nil {
return nil, formatE(ErrGovernanceServiceGetVotes, errors.Wrapf(err, "proposalID: %s", proposalID))
}

if len(edges[i].Node.Proposals) > 0 {
edges[i].Node.ProposalType = vega.GovernanceData_TYPE_BATCH
}
}

proposalsConnection := &v2.GovernanceDataConnection{
Expand Down
Loading

0 comments on commit 10249f6

Please sign in to comment.