Skip to content

Commit

Permalink
Merge pull request #11673 from vegaprotocol/fix/11672
Browse files Browse the repository at this point in the history
fix: add missing fees in gql bindings
  • Loading branch information
jeremyletang authored Sep 11, 2024
2 parents 311e11f + 34baa66 commit 30f651a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

### 🐛 Fixes

- [](https://github.com/vegaprotocol/vega/issues/xxx)
- [11672](https://github.com/vegaprotocol/vega/issues/11672) - Add missing fees in GraphQL bindings.


## 0.78.2
Expand All @@ -34,7 +34,7 @@
- [11650](https://github.com/vegaprotocol/vega/issues/11650) - Add include sub accounts flag to `listPositions`.
- [11641](https://github.com/vegaprotocol/vega/issues/11641) - Panic with pegged orders.
- [11646](https://github.com/vegaprotocol/vega/issues/11646) - Add tier numbers to API.
- [11665](https://github.com/vegaprotocol/vega/issues/11665) - Delay the final termination of a transfer to the following epoch.
- [11665](https://github.com/vegaprotocol/vega/issues/11665) - Delay the final termination of a transfer to the following epoch.


## 0.78.1
Expand Down Expand Up @@ -70,7 +70,7 @@
- [11612](https://github.com/vegaprotocol/vega/issues/11612) - Reward scaling support.
- [11624](https://github.com/vegaprotocol/vega/issues/11624) - prevent creation of rewards with no payout, but with high computational cost.
- [11512](https://github.com/vegaprotocol/vega/issues/11512) - Add loss socialisation amounts to funding payment API.
- [11627](https://github.com/vegaprotocol/vega/issues/11627) - Add eligible keys filter to reward transfers.
- [11627](https://github.com/vegaprotocol/vega/issues/11627) - Add eligible keys filter to reward transfers.

### 🐛 Fixes

Expand Down
4 changes: 4 additions & 0 deletions datanode/gateway/graphql/resolvers.go
Original file line number Diff line number Diff line change
Expand Up @@ -3043,6 +3043,8 @@ func (r *myTradeResolver) BuyerFee(_ context.Context, obj *vegapb.Trade) (*Trade
fee.LiquidityFee = obj.BuyerFee.LiquidityFee
fee.LiquidityFeeReferralDiscount = setIfExists(obj.BuyerFee.LiquidityFeeReferrerDiscount)
fee.LiquidityFeeVolumeDiscount = setIfExists(obj.BuyerFee.LiquidityFeeVolumeDiscount)
fee.TreasuryFee = obj.BuyerFee.TreasuryFee
fee.BuyBackFee = obj.BuyerFee.BuyBackFee
}
return &fee, nil
}
Expand All @@ -3068,6 +3070,8 @@ func (r *myTradeResolver) SellerFee(_ context.Context, obj *vegapb.Trade) (*Trad
fee.LiquidityFee = obj.SellerFee.LiquidityFee
fee.LiquidityFeeReferralDiscount = setIfExists(obj.SellerFee.LiquidityFeeReferrerDiscount)
fee.LiquidityFeeVolumeDiscount = setIfExists(obj.SellerFee.LiquidityFeeVolumeDiscount)
fee.TreasuryFee = obj.SellerFee.TreasuryFee
fee.BuyBackFee = obj.SellerFee.BuyBackFee
}

return &fee, nil
Expand Down

0 comments on commit 30f651a

Please sign in to comment.