Merge pull request #10471 from vegaprotocol/estimate-position-fix

Estimate position fix
vegaprotocol · Jan 23, 2024 · 762bbe2 · 762bbe2
2 parents 921c4c9 + 4be9683
commit 762bbe2
Show file tree

Hide file tree

Showing 5 changed files with 1,858 additions and 1,850 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -151,8 +151,9 @@
 - [10454](https://github.com/vegaprotocol/vega/issues/10454) - Fix account resolver validation to include order margin account.
 - [10451](https://github.com/vegaprotocol/vega/issues/10451) - Fix get update asset bundle.
 - [10419](https://github.com/vegaprotocol/vega/issues/10419) - Block explorer database migration is slow.
-- [10431](https://github.com/vegaprotocol/vega/issues/10431) - Fix source staleness validation. 
+- [10431](https://github.com/vegaprotocol/vega/issues/10431) - Fix source staleness validation.
 - [10419](https://github.com/vegaprotocol/vega/issues/10419) - Block explorer database migration is slow.
+- [10470](https://github.com/vegaprotocol/vega/issues/10470) - Mark non-optional parameters as required and update documentation strings.
 
 ## 0.73.0
 

diff --git a/datanode/api/trading_data_v2.go b/datanode/api/trading_data_v2.go
@@ -3227,6 +3227,9 @@ func (t *TradingDataServiceV2) EstimatePosition(ctx context.Context, req *v2.Est
 
 	dMarginFactor := num.DecimalZero()
 	if req.MarginMode == types.MarginModeIsolatedMargin {
+		if req.MarginFactor == nil {
+			return nil, formatE(ErrMissingMarginFactor, errors.New("margin factor are required with isolated margin"))
+		}
 		dMarginFactor, err = num.DecimalFromString(*req.MarginFactor)
 		if err != nil {
 			return nil, formatE(ErrMissingMarginFactor, err)