Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add LP fees to epoch summaries #9740

Closed
1 task
JonRay15 opened this issue Oct 11, 2023 · 1 comment · Fixed by #9750
Closed
1 task

[Feature]: Add LP fees to epoch summaries #9740

JonRay15 opened this issue Oct 11, 2023 · 1 comment · Fixed by #9750
Assignees
Labels
api feature new feature to be developed fees Al tasks related to the Fees engine

Comments

@JonRay15
Copy link

JonRay15 commented Oct 11, 2023

Feature Overview

In order to allow users to make sense of their earnings on Vega
We will add summaries of LP fees earned to the end of epoch summaries
So that it is clear to users what they have earned

Tasks

A checklist of the tasks that are needed to develop the feature and meet the acceptance criteria and feature test scenarios.

  • Add LP fees earned per epoch to all 3 APIs below

Additional Details (optional)

The current rewards APIs:

  • /api/v2/rewards
  • /api/v2/rewards/epoch/summaries
  • /api/v2/rewards/summaries (Less important ... I have no idea if anyone uses this)

Currently contain per epoch summaries of:

  • Rewards
    • Based on Taker fees paid
    • Based on Maker fees received
    • Based on LP fees received
    • Based on staking (aka "global rewards")
  • Fees
    • Infra fees

It is unclear why this API stops at just the infra fees, when it could provide a per-epoch summary of the LP fees earned and once this was done this API would provide a holistic picture of all the rewards & fees that a party has earned per epoch.

We want to add these to it...

@JonRay15 JonRay15 added the feature new feature to be developed label Oct 11, 2023
@gordsport gordsport added fees Al tasks related to the Fees engine api labels Oct 11, 2023
@gordsport gordsport moved this to Todo in Core Kanban Oct 11, 2023
@gordsport gordsport added this to the ☄️ Cosmic Elevator milestone Oct 11, 2023
@karlem karlem moved this from Todo to In Progress in Core Kanban Oct 11, 2023
@gordsport gordsport changed the title [Feature]: Add LP fees and maker fees to epoch summaries [Feature]: Add LP fees to epoch summaries Oct 11, 2023
@gordsport
Copy link
Contributor

Issue has been split leave LP fees in this one. Maker fees to be done under:

@vega-issues vega-issues moved this from In Progress to Waiting Review in Core Kanban Oct 13, 2023
@vega-issues vega-issues moved this from Waiting Review to In Review in Core Kanban Oct 16, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Oct 16, 2023
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban Oct 16, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Oct 16, 2023
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api feature new feature to be developed fees Al tasks related to the Fees engine
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants