New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new liquidity stats to core #9750

Merged

jeremyletang merged 21 commits into develop from feat-9740

Oct 16, 2023

Contributor

karlem commented Oct 11, 2023

Close #9740

karlem force-pushed the feat-9740 branch 6 times, most recently from 3137111 to 54a8e59 Compare

October 13, 2023 17:22

karlem marked this pull request as ready for review

October 13, 2023 17:22

karlem requested review from candida-d, gordsport and a team as code owners

October 13, 2023 17:22

wwestgarth reviewed

View reviewed changes

protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved

wwestgarth reviewed

View reviewed changes

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

wwestgarth reviewed

View reviewed changes

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

wwestgarth reviewed

View reviewed changes

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

karlem force-pushed the feat-9740 branch from 54a8e59 to 269e931 Compare

October 16, 2023 12:00

wwestgarth reviewed

View reviewed changes

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

karlem force-pushed the feat-9740 branch from b933177 to 2a7f230 Compare

October 16, 2023 12:33

wwestgarth reviewed

View reviewed changes

protos/sources/data-node/api/v2/trading_data.proto Show resolved Hide resolved

karlem force-pushed the feat-9740 branch from 960d44d to 3af1c06 Compare

October 16, 2023 15:08

EVODelavega reviewed

View reviewed changes

core/types/liquidity_fee_stats_test.go Outdated Show resolved Hide resolved

EVODelavega reviewed

View reviewed changes

datanode/sqlstore/paid_liquidity_fee_stats_test.go Show resolved Hide resolved

karlem force-pushed the feat-9740 branch from 3af1c06 to fae2e46 Compare

October 16, 2023 15:35

candida-d reviewed

View reviewed changes

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

protos/sources/data-node/api/v2/trading_data.proto Show resolved Hide resolved

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

protos/sources/data-node/api/v2/trading_data.proto Show resolved Hide resolved

protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved

EVODelavega previously approved these changes

View reviewed changes

jeremyletang dismissed EVODelavega’s stale review via

51a319e

October 16, 2023 17:22

karlem added 4 commits

October 16, 2023 18:42


          feat: add new liquidity stats to core

445fd2d


          feat: move fee stats to LP engine

315d683


          feat: add to snapshot

04e21cd


          feat: added data node side

2e1092b

karlem and others added 15 commits

October 16, 2023 18:43


          feat: finish the query

bc4ae36


          feat: rename & add more tests

2c0b670


          feat: add graphql

ac8cf4c


          feat: add changelog


          feat: fix and update

8bba5fa


          feat: renamed file

cad7a56


          feat: fix and lint

63e1b6d


          fix: small fixes

b0e749f


          feat: apply suggestions from code review

d66cc79

Co-authored-by: wwestgarth <[email protected]>


          feat: fix test

4e5e5e5


          feat: fix database issue

227d8f5


          fix: do not spam the DB

adbfb0a


          fix: test and comments

97cd7aa


          chore: Apply suggestions from code review

9ca031f

Co-authored-by: candida-d <[email protected]>
Co-authored-by: wwestgarth <[email protected]>


          chore: fix proto + regenerate

8dbebdf

Signed-off-by: Jeremy Letang <[email protected]>

jeremyletang force-pushed the feat-9740 branch from 909d263 to 8dbebdf Compare

October 16, 2023 17:43

candida-d reviewed

View reviewed changes

protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved

candida-d reviewed

View reviewed changes

protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved


          chore: Apply suggestions from code review

ee6120b

Co-authored-by: candida-d <[email protected]>

candida-d previously approved these changes

View reviewed changes

jeremyletang previously approved these changes

View reviewed changes

EVODelavega previously approved these changes

View reviewed changes


          chore: recompile protos

ed559df

Signed-off-by: Jeremy Letang <[email protected]>

jeremyletang dismissed stale reviews from EVODelavega, candida-d, and themself via

ed559df

October 16, 2023 18:28

EVODelavega approved these changes

View reviewed changes

jeremyletang approved these changes

View reviewed changes

jeremyletang merged commit 0854b6c into develop

jeremyletang deleted the feat-9740 branch

October 16, 2023 18:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wwestgarth wwestgarth left review comments

jeremyletang jeremyletang approved these changes

EVODelavega EVODelavega approved these changes

candida-d candida-d left review comments

gordsport Awaiting requested review from gordsport

Labels

None yet