Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Transfer account validation to account for network treasury #9788

Closed
EVODelavega opened this issue Oct 16, 2023 · 0 comments · Fixed by #9791
Closed

[Feature]: Transfer account validation to account for network treasury #9788

EVODelavega opened this issue Oct 16, 2023 · 0 comments · Fixed by #9791
Assignees
Labels
feature new feature to be developed

Comments

@EVODelavega
Copy link
Contributor

The validation in commands/transer_funds.go dates back to before the account type NETWORK_TREASURY existed. As a result, some of the transfers that are outlined in the spec may not pass the validation while they ought to.

The validation changes under this issue should be made to conform to the spec, accounting for the new account types that were introduced.

@EVODelavega EVODelavega added the feature new feature to be developed label Oct 16, 2023
@EVODelavega EVODelavega added this to the ☄️ Cosmic Elevator milestone Oct 16, 2023
@EVODelavega EVODelavega self-assigned this Oct 16, 2023
@gordsport gordsport moved this to In Progress in Core Kanban Oct 16, 2023
@vega-issues vega-issues moved this from In Progress to Waiting Review in Core Kanban Oct 16, 2023
@vega-issues vega-issues moved this from Waiting Review to In Review in Core Kanban Oct 16, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Oct 16, 2023
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature to be developed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant