fix: validation on governance proposals #9791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVODelavega
force-pushed
the
9788-transfer-funds-validation
branch
2 times, most recently
from
8ac66bc to
28df2e7
Compare
Signed-off-by: Elias Van Ootegem <[email protected]>
Signed-off-by: Elias Van Ootegem <[email protected]>
EVODelavega
force-pushed
the
9788-transfer-funds-validation
branch
from
28df2e7 to
c7e8b25
Compare
ze97286
reviewed
Oct 16, 2023
ze97286
reviewed
Oct 16, 2023
ze97286
reviewed
Oct 16, 2023
| return errs.FinalAddForProperty("proposal_submission.terms.change.new_transfer.changes.source", ErrIsNotValid) | ||
| } | ||
| // destination == source | ||
| if dest == changes.SourceType && changes.Source == changes.Destination { |
There was a problem hiding this comment.
doesn't this apply to any source type?
There was a problem hiding this comment.
It does, but because of the map, I believe the only one where this check is actually required is market insurance pools
Signed-off-by: Elias Van Ootegem <[email protected]>
ze97286
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9788
Based the validation on the spec: https://github.com/vegaprotocol/specs/blob/cosmicelevator/protocol/0028-GOVE-governance.md#permitted-source-and-destination-account-types