Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction result subscription #9802

Closed
gordsport opened this issue Oct 16, 2023 · 1 comment · Fixed by #9955
Closed

Transaction result subscription #9802

gordsport opened this issue Oct 16, 2023 · 1 comment · Fixed by #9955
Assignees
Labels

Comments

@gordsport
Copy link
Contributor

Front-end apps have accrued significant technical debt in managing the UI surrounding different transaction types.

Once a transaction is sent to a wallet different subscriptions and logic is needed to properly track the transaction and the resulting changes on the network.

As a result the TransactionResult bus event was added, but it only gets us part of the way there.

This work is to improve that or add a new subscription specifically for this purpose, so that you can easily track transactions and the changes that result from them.

This should also be beneficial in making it easier for external people to build on Vega

@gordsport gordsport moved this to Todo in Core Kanban Oct 16, 2023
@gordsport gordsport added the api label Oct 16, 2023
@gordsport gordsport assigned karlem and unassigned mattrussell36 Oct 24, 2023
@karlem karlem moved this from Todo to In Progress in Core Kanban Oct 30, 2023
@mattrussell36
Copy link
Contributor

I've put together a proposal of how this could look here: https://www.notion.so/vegaprotocol/Transaction-subscriptions-for-front-ends-75d6c18b2c96440387d8dfe6855d28bb?pvs=4

Please have a look. Open to any suggestions

@vega-issues vega-issues moved this from In Progress to Waiting Review in Core Kanban Nov 1, 2023
@vega-issues vega-issues moved this from Waiting Review to In Review in Core Kanban Nov 2, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Nov 6, 2023
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban Nov 6, 2023
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban Nov 6, 2023
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants