Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transaction result subscription #9955

Merged
merged 10 commits into from
Nov 6, 2023
Merged

feat: add transaction result subscription #9955

merged 10 commits into from
Nov 6, 2023

Conversation

karlem
Copy link
Contributor

@karlem karlem commented Nov 1, 2023 •
edited
Loading

Close #9802

@karlem karlem requested review from candida-d, gordsport and a team as code owners November 1, 2023 19:55
@karlem karlem force-pushed the feat-9802 branch 2 times, most recently from 00005fb to afa02c1 Compare November 2, 2023 21:01
@wwestgarth
Copy link
Contributor

wwestgarth commented Nov 3, 2023 •
edited
Loading

I just went to give it a whirl with vegacapsule and got this panic when I hit the new endpoint:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x10473204c]

goroutine 1907 [running]:
code.vegaprotocol.io/vega/datanode/sqlsubscribers.(*TransactionResults).Observe(0x0, {0x1063139b8, 0x1400016a4b0}, 0x105f3e580?, {0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}, ...)
	/Users/wwestgarth/work/vega/datanode/sqlsubscribers/transaction_results.go:72 +0xdc
code.vegaprotocol.io/vega/datanode/api.(*TradingDataServiceV2).ObserveTransactionResults(0x140019f8500, 0x1400408ec60, {0x1063244c0, 0x1400017b470})
	/Users/wwestgarth/work/vega/datanode/api/trading_data_v2.go:4750 +0xcc
code.vegaprotocol.io/vega/protos/data-node/api/v2._TradingDataService_ObserveTransactionResults_Handler({0x106299b40?, 0x140019f8500}, {0x106321720, 0x140016d8000})
	/Users/wwestgarth/work/vega/protos/data-node/api/v2/trading_data_grpc.pb.go:4963 +0xd4
code.vegaprotocol.io/vega/datanode/gateway.(*SubscriptionRateLimiter).WithGrpcInterceptor.func1({0x106299b40, 0x140019f8500}, {0x106321720?, 0x140016d8000?}, 0x140001fc900, 0x1062c73b0)
	/Users/wwestgarth/work/vega/datanode/gateway/middleware.go:237 +0x2ec

@karlem
Copy link
Contributor Author

karlem commented Nov 3, 2023

@wwestgarth thanks for the review. I have fixed it.

mattrussell36
mattrussell36 previously approved these changes Nov 3, 2023
View reviewed changes
wwestgarth
wwestgarth previously approved these changes Nov 6, 2023
View reviewed changes
@karlem karlem dismissed stale reviews from wwestgarth and mattrussell36 via 56f70fd November 6, 2023 12:48
wwestgarth
wwestgarth previously approved these changes Nov 6, 2023
View reviewed changes
@jeremyletang jeremyletang merged commit d34d273 into develop Nov 6, 2023
15 checks passed
@jeremyletang jeremyletang deleted the feat-9802 branch November 6, 2023 14:28
@gordsport gordsport added the feature new feature to be developed label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candida-d candida-d candida-d left review comments

@ValentinTrinque ValentinTrinque ValentinTrinque approved these changes

@mattrussell36 mattrussell36 mattrussell36 left review comments

@wwestgarth wwestgarth wwestgarth left review comments

@gordsport gordsport Awaiting requested review from gordsport

Assignees
No one assigned
Labels
feature new feature to be developed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction result subscription
7 participants
@karlem @wwestgarth @ValentinTrinque @mattrussell36 @candida-d @jeremyletang @gordsport