Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquidation strategy #10006

Merged
merged 11 commits into from
Nov 7, 2023
Merged

Liquidation strategy #10006

merged 11 commits into from
Nov 7, 2023

Conversation

EVODelavega
Copy link
Contributor

First part of issue #9945: Update market framework

@EVODelavega EVODelavega requested review from candida-d, gordsport and a team as code owners November 7, 2023 10:05
jeremyletang
jeremyletang requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@jeremyletang jeremyletang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the commands package validation as well please?

candida-d
candida-d previously approved these changes Nov 7, 2023
View reviewed changes
candida-d
candida-d previously approved these changes Nov 7, 2023
View reviewed changes
@EVODelavega EVODelavega requested a review from a team as a code owner November 7, 2023 14:32
candida-d
candida-d reviewed Nov 7, 2023
View reviewed changes
datanode/gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
datanode/gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
protos/sources/vega/markets.proto Outdated Show resolved Hide resolved
protos/sources/vega/markets.proto Outdated Show resolved Hide resolved
@EVODelavega
feat: add liquidation strategy to market framework
80450d7 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
fix: update governance unit tests
956743b 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: set liquidation strategy on new market
7a768d4 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: add liquidation strategy validation to governance engine
b05045a 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: code review
8d158c7 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: typo
5eddb82 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
fix: unit tests
95d89e0 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
fix: system-tests nil pointer
c9fa744 
Signed-off-by: Elias Van Ootegem <[email protected]>
candida-d
candida-d previously approved these changes Nov 7, 2023
View reviewed changes
@EVODelavega
feat: add GQL API
8847fdb 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
fix: proto and gql review
7ff8b3d 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega
feat: add validation tests for commands
b4040e7 
Signed-off-by: Elias Van Ootegem <[email protected]>
@EVODelavega EVODelavega merged commit 5877f4e into develop Nov 7, 2023
@EVODelavega EVODelavega deleted the liquidation-strategy branch November 7, 2023 16:41
@gordsport gordsport linked an issue Nov 7, 2023 that may be closed by this pull request
[Liquidation improvements] Completely decouple MTM, margin checks and closeout trades #9945
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordsport gordsport gordsport approved these changes

@candida-d candida-d candida-d approved these changes

@jeremyletang jeremyletang jeremyletang approved these changes

@wwestgarth wwestgarth Awaiting requested review from wwestgarth

Assignees
No one assigned
Labels
breaking-change no-issue
Projects
Core Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Liquidation improvements] Completely decouple MTM, margin checks and closeout trades
5 participants
@EVODelavega @wwestgarth @jeremyletang @candida-d @gordsport