Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the block explorer pagination follows the natural order for an explorer #10224

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Ensure the block explorer pagination follows the natural order for an explorer #10224

merged 1 commit into from
Dec 8, 2023

Conversation

ValentinTrinque
Copy link
Contributor

Close #10215

@ValentinTrinque ValentinTrinque self-assigned this Dec 5, 2023
@ValentinTrinque ValentinTrinque changed the base branch from develop to fix/10193 December 5, 2023 18:05
@ValentinTrinque ValentinTrinque force-pushed the fix/10215 branch 2 times, most recently from 0951b87 to e049643 Compare December 5, 2023 18:14
@ValentinTrinque ValentinTrinque force-pushed the fix/10193 branch 6 times, most recently from 046cdda to ce20ca3 Compare December 6, 2023 13:19
@ValentinTrinque ValentinTrinque changed the title Ensure the block explorer paginate is the right order Ensure the block explorer pagination follows the natural order for an explorer Dec 6, 2023
@ValentinTrinque ValentinTrinque force-pushed the fix/10215 branch 2 times, most recently from 59a21de to ed71420 Compare December 6, 2023 13:29
@ValentinTrinque ValentinTrinque force-pushed the fix/10215 branch 2 times, most recently from f076cb3 to 135f27e Compare December 6, 2023 13:33
Base automatically changed from fix/10193 to develop December 6, 2023 17:17
@ValentinTrinque ValentinTrinque force-pushed the fix/10215 branch 4 times, most recently from 045fea1 to 3571851 Compare December 7, 2023 11:17
guoguojin
guoguojin previously approved these changes Dec 8, 2023
View reviewed changes
@ValentinTrinque ValentinTrinque merged commit 0d52f1a into develop Dec 8, 2023
17 checks passed
@ValentinTrinque ValentinTrinque deleted the fix/10215 branch December 8, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoguojin guoguojin guoguojin approved these changes

@candida-d candida-d candida-d approved these changes

@gordsport gordsport Awaiting requested review from gordsport

Assignees

@ValentinTrinque ValentinTrinque

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blockexplorer pagination feels unatural
4 participants
@ValentinTrinque @guoguojin @candida-d @gordsport