Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a FT to replicate bug found in incentive #11202

Merged
merged 11 commits into from
Apr 26, 2024
Merged

feat: add a FT to replicate bug found in incentive #11202

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e6f95a
feat: add a FT to replicate bug found in incentive
Jiajia-Cui Apr 26, 2024
e7492d6
chore: update for position decimal
Jiajia-Cui Apr 26, 2024
a0a1140
chore: update for decimal
Jiajia-Cui Apr 26, 2024
b7aa15d
feat: add account check
Jiajia-Cui Apr 26, 2024
603a34a
chore: update btc price
Jiajia-Cui Apr 26, 2024
16abd2c
feat: add sell market order
Jiajia-Cui Apr 26, 2024
369454f
chore: update name
Jiajia-Cui Apr 26, 2024
63f0e4a
Merge branch 'develop' into spot-bug
ze97286 Apr 26, 2024
f72d300
fix: added more checks for party sufficient balance on submit and amend
ze97286 Apr 26, 2024
3de316b
feat: add more FTs
Jiajia-Cui Apr 26, 2024
fa37bdf
feat: add more scenario for partially trade
Jiajia-Cui Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions core/integration/features/spot/orders/0080-SPOT-024.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Feature: Spot market bug (from the incentive) replication

Scenario: 0080-SPOT-024, 0080-SPOT-025 market orders should be rejected when traders do not have enough collateral to cover the trades in spot market
Scenario: 0080-SPOT-024, 0080-SPOT-025 market orders should be rejected when traders do not have enough collateral to cover the trades in spot market
Background:

Given the following network parameters are set:
Expand Down Expand Up @@ -82,11 +82,11 @@ Feature: Spot market bug (from the incentive) replication

And the parties place the following orders:
| party | market id | side | volume | price | resulting trades | type | tif | reference | error |
| party3 | BTC/USD | buy | 20 | 0 | 0 | TYPE_MARKET | TIF_IOC | | insufficient funds for order |
| party3 | BTC/USD | buy | 20 | 0 | 0 | TYPE_MARKET | TIF_IOC | p3-b1 | insufficient funds for order |

And the parties place the following orders:
| party | market id | side | volume | price | resulting trades | type | tif | reference | error |
| party4 | BTC/USD | sell | 10 | 0 | 0 | TYPE_MARKET | TIF_IOC | | party does not have sufficient balance to cover the trade and fees |
| party4 | BTC/USD | sell | 10 | 0 | 0 | TYPE_MARKET | TIF_IOC | p4-s1 | party does not have sufficient balance to cover the trade and fees |

Then the network moves ahead "1" blocks

Expand All @@ -98,4 +98,29 @@ Feature: Spot market bug (from the incentive) replication
Then "party3" should have general account balance of "1000" for asset "USD"
Then "party4" should have general account balance of "1" for asset "BTC"

And the parties place the following orders:
| party | market id | side | volume | price | resulting trades | type | tif | reference | error |
| party3 | BTC/USD | buy | 20 | 10 | 0 | TYPE_LIMIT | TIF_GTC | p3-b2 | |

And the parties place the following orders:
| party | market id | side | volume | price | resulting trades | type | tif | reference | error |
| party4 | BTC/USD | sell | 1 | 66000 | 0 | TYPE_LIMIT | TIF_GTC | p4-s2 | |

#0080-SPOT-026: amend order - order is amended such that would trade immediately and the party can't afford none/some of the trades
When the parties amend the following orders:
| party | reference | price | size delta | tif | error |
| party3 | p3-b2 | 66000 | -10 | TIF_GTC | party does not have sufficient balance to cover the trade and fees |
Jiajia-Cui marked this conversation as resolved.
Show resolved Hide resolved
| party4 | p4-s2 | 59000 | 2 | TIF_GTC | party does not have sufficient balance to cover the new size |

#0080-SPOT-027:submit order - limit order, partly matched, party can't afford the trades
Jiajia-Cui marked this conversation as resolved.
Show resolved Hide resolved
And the parties place the following orders:
| party | market id | side | volume | price | resulting trades | type | tif | reference | error |
| party3 | BTC/USD | buy | 6 | 6100 | 0 | TYPE_LIMIT | TIF_GTC | p3-b3 | party does not have sufficient balance to cover the trade and fees |

#0080-SPOT-028:submit order - limit order, no match, added to the book, party can't cover the amount that needs to be transfered to the holding
And the parties place the following orders:
| party | market id | side | volume | price | resulting trades | type | tif | reference | error |
| party4 | BTC/USD | sell | 2 | 67000 | 0 | TYPE_LIMIT | TIF_GTC | p4-s3 | party does not have sufficient balance to cover the trade and fees |



Loading