-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish ongoing game data #11223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze97286
force-pushed
the
fix_ti_schema
branch
4 times, most recently
from
May 1, 2024 14:34
744f82a
to
451d3a4
Compare
candida-d
reviewed
May 1, 2024
string trade_volume = 5; | ||
// Total fees paid by the party during the relevant period. | ||
string total_fees_paid = 6; | ||
// Is the party eligible for reward for this game based on the current information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Is the party eligible for reward for this game based on the current information. | |
// If the party is eligible for a reward for this game based on the current information. |
ze97286
force-pushed
the
fix_ti_schema
branch
7 times, most recently
from
May 10, 2024 07:44
3de1ee9
to
d53a95e
Compare
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
wwestgarth
reviewed
May 10, 2024
peterbarrow
previously approved these changes
May 10, 2024
peterbarrow
previously approved these changes
May 10, 2024
candida-d
reviewed
May 13, 2024
EVODelavega
previously approved these changes
May 13, 2024
EVODelavega
previously approved these changes
May 13, 2024
cdummett
previously approved these changes
May 13, 2024
candida-d
reviewed
May 13, 2024
cdummett
approved these changes
May 14, 2024
candida-d
approved these changes
May 14, 2024
EVODelavega
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11209
what's missing: deprecate existing API - which will be done separately.