Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish ongoing game data #11223

Merged
merged 2 commits into from
May 14, 2024
Merged

feat: publish ongoing game data #11223

merged 2 commits into from
May 14, 2024

Conversation

ze97286
Copy link
Contributor

@ze97286 ze97286 commented May 1, 2024

Closes #11209

what's missing: deprecate existing API - which will be done separately.

@ze97286 ze97286 requested review from candida-d and a team as code owners May 1, 2024 12:47
@ze97286 ze97286 force-pushed the fix_ti_schema branch 4 times, most recently from 744f82a to 451d3a4 Compare May 1, 2024 14:34
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
string trade_volume = 5;
// Total fees paid by the party during the relevant period.
string total_fees_paid = 6;
// Is the party eligible for reward for this game based on the current information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Is the party eligible for reward for this game based on the current information.
// If the party is eligible for a reward for this game based on the current information.

protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
protos/sources/vega/events/v1/events.proto Outdated Show resolved Hide resolved
@ze97286 ze97286 requested a review from a team as a code owner May 7, 2024 11:00
@ze97286 ze97286 force-pushed the fix_ti_schema branch 7 times, most recently from 3de1ee9 to d53a95e Compare May 10, 2024 07:44
peterbarrow
peterbarrow previously approved these changes May 10, 2024
datanode/gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
peterbarrow
peterbarrow previously approved these changes May 10, 2024
datanode/gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
datanode/gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
datanode/gateway/graphql/schema.graphql Outdated Show resolved Hide resolved
protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved
protos/sources/data-node/api/v2/trading_data.proto Outdated Show resolved Hide resolved
EVODelavega
EVODelavega previously approved these changes May 13, 2024
EVODelavega
EVODelavega previously approved these changes May 13, 2024
cdummett
cdummett previously approved these changes May 13, 2024
@jeremyletang jeremyletang merged commit 9b6a803 into develop May 14, 2024
14 checks passed
@jeremyletang jeremyletang deleted the fix_ti_schema branch May 14, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish ongoing games data
7 participants