test: add coverage for protective auction ACs #11496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze97286
reviewed
Jul 24, 2024
ze97286
reviewed
Jul 24, 2024
ze97286
reviewed
Jul 24, 2024
| if m.mkt.TradingMode == types.MarketTradingModeSuspendedViaGovernance { | ||
| return | ||
| } | ||
|
|
||
| m.mkt.State = types.MarketStateSuspended | ||
| m.mkt.TradingMode = types.MarketTradingModelLongBlockAuction |
There was a problem hiding this comment.
I think this is still wrong you know? or at least out of place. If we're not in an auction then it's correct. But if we are in an auction I'm not sure we should do either of these.
Signed-off-by: Elias Van Ootegem <[email protected]>
Signed-off-by: Elias Van Ootegem <[email protected]>
Signed-off-by: Elias Van Ootegem <[email protected]>
Signed-off-by: Elias Van Ootegem <[email protected]>
jeremyletang
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also included some more unit testing to processor package, changed the
log.Fatalcall in the protocol upgrade flow to alog.Panicto be able to recover in a unit test, to check that code-path.