Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve performance with the ackedEvent store #11498

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jeremyletang
Copy link
Member

Two things have been done here:

  • first the buckets are for one hour instead of one per timestamps.
  • hashes are stored in a map not a slice anymore to avoid long iterations

close #11497

@jeremyletang jeremyletang requested a review from a team as a code owner July 24, 2024 14:34
@wwestgarth
Copy link
Contributor

In one of the previous panics about eth-call events being annoying, I lazily made a copy of acked_events.go in core/datasource/external/ethverifier...

Its probably worth copy+pasting this fix into that file too (or combining somehow if you can be bothered).

@jeremyletang jeremyletang force-pushed the feature/improve-acked-events branch from dadb94f to 2c73ba4 Compare July 24, 2024 15:08
@jeremyletang jeremyletang force-pushed the feature/improve-acked-events branch from 2c73ba4 to 8f5051e Compare July 24, 2024 15:16
@jeremyletang
Copy link
Member Author

In one of the previous panics about eth-call events being annoying, I lazily made a copy of acked_events.go in core/datasource/external/ethverifier...

Its probably worth copy+pasting this fix into that file too (or combining somehow if you can be bothered).

Addressed and rebased.

@jeremyletang jeremyletang merged commit c7f33ce into develop Jul 24, 2024
16 checks passed
@jeremyletang jeremyletang deleted the feature/improve-acked-events branch July 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issue with storing the acked events
2 participants