Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add FT for high volume maker rebate #11557

Merged
merged 8 commits into from
Aug 13, 2024
Merged

feat: add FT for high volume maker rebate #11557

merged 8 commits into from
Aug 13, 2024

Conversation

Jiajia-Cui
Copy link
Contributor

@Jiajia-Cui Jiajia-Cui commented Aug 12, 2024 •
edited
Loading

@Jiajia-Cui Jiajia-Cui marked this pull request as ready for review August 13, 2024 11:37
@Jiajia-Cui Jiajia-Cui requested a review from a team as a code owner August 13, 2024 11:37
cdummett
cdummett reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers look good, two small comments

core/integration/features/fees/0029-FEES-high_volume_maker.feature Outdated Show resolved Hide resolved
@EVODelavega EVODelavega merged commit f2ad5d3 into develop Aug 13, 2024
16 of 20 checks passed
@EVODelavega EVODelavega deleted the high-volume-maker-rebate-FT branch August 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdummett cdummett cdummett left review comments

@EVODelavega EVODelavega EVODelavega approved these changes

Assignees
No one assigned
Labels
no-changelog no-issue
Projects
Core Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiajia-Cui @EVODelavega @cdummett