Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scale map to asset decimals before comparisons in estimate-posit… #11620

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: scale map to asset decimals before comparisons in estimate-posit… #11620

merged 1 commit into from
Aug 28, 2024

Conversation

wwestgarth
Copy link
Contributor

@wwestgarth wwestgarth commented Aug 28, 2024 •
edited
Loading

closes #11619

Three things changed here:

  • capped-price is now scaled to asset-dps so it is of the same order as all the other prices
  • if one of the given hypothetical orders is outside of the capped price range, the API returns an error
  • one of the calculations has been fixed, it was using cappedPrice instead of averageEntryPrice

@wwestgarth wwestgarth requested a review from a team as a code owner August 28, 2024 10:35
@wwestgarth wwestgarth force-pushed the 11619-capped-estimates branch from 19c8d88 to 5a12a14 Compare August 28, 2024 10:42
@wwestgarth wwestgarth force-pushed the 11619-capped-estimates branch from 5a12a14 to 6929dc6 Compare August 28, 2024 10:43
@wwestgarth wwestgarth merged commit 94d5319 into develop Aug 28, 2024
15 of 16 checks passed
@wwestgarth wwestgarth deleted the 11619-capped-estimates branch August 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: EstimatePosition does not scale mcap before comparison
2 participants
@wwestgarth @jeremyletang