fix: prevent overflow when calculating tradable volume outside of sid… #11639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error came up on a market-sim run:
and is due to my re-write of
TradableVolumeInRange()
to be entirely position based. I missed the case where we query a range, the pool's current position exists outside of that range on the wrong side. For example, if we want the buy volume of an AMM between position[30, 10]
but the AMM's current position is50
then there is no buy volume, its already been traded.