fix: check for empty tier slices and use int for slice indexes #11675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elias Van Ootegem <[email protected]>
ze97286
approved these changes
Sep 11, 2024
jeremyletang
added a commit
that referenced
this pull request
Sep 12, 2024
fix: check for empty tier slices and use int for slice indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for panic. Since a slice index is specified either untyped, or its core type must be an integer, non-negative and representable by a value of type
int, decided it best to haveibe of typeint, and only convert it touint64when assigning the tier number pointer