Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recalculate stats when the program is updated #11700

Merged
merged 8 commits into from
Sep 23, 2024

Conversation

EVODelavega
Copy link
Contributor

Closes #11699

@EVODelavega EVODelavega requested a review from a team as a code owner September 18, 2024 15:53
@cdummett cdummett requested a review from a team as a code owner September 20, 2024 14:16
@cdummett
Copy link
Contributor

Hey @EVODelavega, currently stats are being calculated correctly at the start of the epoch after an existing program is being updated 👍

e.g. these are all passing

go test -v ./core/integration/... --godog.format=pretty $(pwd)/core/integration/features/verified/enactment_HVMR.feature:115
go test -v ./core/integration/... --godog.format=pretty $(pwd)/core/integration/features/verified/enactment_VDPR.feature:111
go test -v ./core/integration/... --godog.format=pretty $(pwd)/core/integration/features/verified/enactment_RFPR.feature:121

But the stats are not being calculated at the start of the first epoch after a program is enacted when there is no program already active...

e.g. these are failing

go test -v ./core/integration/... --godog.format=pretty $(pwd)/core/integration/features/verified/enactment_HVMR.feature:74
go test -v ./core/integration/... --godog.format=pretty $(pwd)/core/integration/features/verified/enactment_VDPR.feature:73
go test -v ./core/integration/... --godog.format=pretty $(pwd)/core/integration/features/verified/enactment_RFPR.feature:80

@EVODelavega EVODelavega merged commit 7887a8a into develop Sep 23, 2024
16 checks passed
@EVODelavega EVODelavega deleted the 11699-update-factors branch September 23, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: reorder processing of updating programs and setting party benefit factors
3 participants