fix: do not pay referal discount if set is not eligible #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze97286
reviewed
Oct 13, 2023
| @@ -558,6 +558,10 @@ func (e *Engine) computeFactorsByReferee(ctx context.Context, epoch uint64, take | |||
| e.factorsByReferee[party] = refereeStats | |||
| setStats.RefereesStats[party] = refereeStats | |||
|
|
|||
| if e.isSetEligible(setID) != nil { | |||
There was a problem hiding this comment.
why go all the way to here rather than do this in line 537 for example?
There was a problem hiding this comment.
Because I wanted these:
558 e.factorsByReferee[party] = refereeStats
559 setStats.RefereesStats[party] = refereeStats
To be set with set.
There was a problem hiding this comment.
but why? they'll just be 0 won't they?
There was a problem hiding this comment.
yes, but we will want the taker volume stats to be stored accross the epoch and sent to the datanode.
There was a problem hiding this comment.
basically we still want the refereeStats to be updated.
EVODelavega
approved these changes
Oct 13, 2023
Signed-off-by: Jeremy Letang <[email protected]>
jeremyletang
force-pushed
the
fix/9775
branch
from
15a4ff2 to
6e47e3d
Compare
ze97286
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9775