New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling with with Scala 2.12.4 and JavaFX 11 modules #164

Open

oscarvarto wants to merge 1 commit into vegas-viz:master from oscarvarto:javafx11

oscarvarto commented Nov 20, 2018

This PR is for a release that works with scalaVersion := 2.12.4, and uses JavaFX 11 modules.
I am not adding new functionality, I just updated the dependencies.
All tests are passing.


          Compiling with with Scala 2.12.4 and JavaFX 11 modules

0720c6b

Author

oscarvarto commented Nov 20, 2018

For Java > 9, OpenJFX requires a separate installation, and the build must be able to find the additional jars.

It is possible that the travis build doesn't consider that, and that it is assuming Java 8.

f1yegor mentioned this pull request

Crosscompile #174

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet