Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vf 166 lag tab komponent #385

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Vf 166 lag tab komponent #385

merged 13 commits into from
Jan 23, 2025

Conversation

juliadai8
Copy link
Contributor

@juliadai8 juliadai8 commented Dec 28, 2024 •
edited by FilipSkaug
Loading

Describe your changes 📖

Bruke det nye designet av tab komponenten i Team og Kontakt oss siden

Jira ticket: 🔖

VF-166

Checklist before requesting a review ✔️

  • I have performed a self-review of my code
  • I have verified that the code works as intended
  • Pipeline runs successfully
  • Sonarcloud scan passes
  • Unit tests passes

@linear Linear
Copy link

linear bot commented Dec 28, 2024

VF-166 Lag tab komponent

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@FilipSkaug FilipSkaug self-requested a review January 23, 2025 09:20
@FilipSkaug
Copy link
Contributor

LWGTM!

@FilipSkaug FilipSkaug enabled auto-merge January 23, 2025 09:43
@FilipSkaug
Copy link
Contributor

lgtm

FilipSkaug
FilipSkaug approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@FilipSkaug FilipSkaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilipSkaug FilipSkaug added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 2b3feae Jan 23, 2025
2 of 6 checks passed
@FilipSkaug FilipSkaug deleted the vf-166-lag-tab-komponent branch January 23, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipSkaug FilipSkaug FilipSkaug approved these changes

Assignees

@juliadai8 juliadai8

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliadai8 @FilipSkaug