Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tickers #12

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Fix tickers #12

merged 5 commits into from
Mar 21, 2024

Conversation

callmephilip
Copy link
Contributor

This fixes issues with frozen tickers. Migrated to the latest version of sugar with some adjustments.

@stas some tests are failing when running on https://mainnet.optimism.io (out of gas). can we set a WEB3_PROVIDER_URI secret for GH actions to an Alchemy endpoint - I don't have access to secrets for the repo 🙆‍♂️

@callmephilip callmephilip requested a review from stas March 20, 2024 19:25
@stas
Copy link
Contributor

stas commented Mar 20, 2024

@stas some tests are failing when running on https://mainnet.optimism.io (out of gas). can we set a WEB3_PROVIDER_URI secret for GH actions to an Alchemy endpoint - I don't have access to secrets for the repo 🙆‍♂️

Let's use one of these:

  • https://optimism-mainnet.wallet.coinbase.com
  • https://optimism-rpc.publicnode.com

For base as well

  • https://base-rpc.publicnode.com

@callmephilip
Copy link
Contributor Author

@stas https://optimism-mainnet.wallet.coinbase.com seems to work. also updated deps to address security issues. ready for review

Copy link
Contributor

@stas stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's roll it out ⚡

@callmephilip callmephilip merged commit 1b1461a into main Mar 21, 2024
1 check passed
@callmephilip callmephilip deleted the fix/tickers branch March 21, 2024 09:51
callmephilip added a commit to aerodrome-finance/bots that referenced this pull request Apr 30, 2024
* add sugar and oracle to pre reqs

* Fix tickers (velodrome-finance#12)

* update sugar address

* migrate to new sugar

* update WEB3_PROVIDER_URI

* update deps

* lint

* fresh ABIs

* clean up legacy velodrome left overs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants