Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vl/20241209 #108

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Vl/20241209 #108

merged 1 commit into from
Dec 10, 2024

Conversation

mrbald
Copy link
Collaborator

@mrbald mrbald commented Dec 9, 2024

No description provided.

@mrbald mrbald changed the base branch from master to cxx23 December 9, 2024 20:25
@cxx24 cxx24 self-requested a review December 10, 2024 06:39
cxx24
cxx24 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@cxx24 cxx24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.
Not sure if changing boost::scoped_ptr
which guarantees ownership is not transferred ( moved ) as in std::unique_ptr which can be swapped / moved to new owner is needed?

@abushev abushev merged commit bb7f759 into cxx23 Dec 10, 2024
3 checks passed
@abushev abushev deleted the vl/20241209 branch December 10, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxx24 cxx24 cxx24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrbald @cxx24 @abushev