Add validation for MAC and IP addresses in Measurement.Valid method #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravjot Singh <[email protected]>
Signed-off-by: Ravjot Singh <[email protected]>
Signed-off-by: Ravjot Singh <[email protected]>
There was a problem hiding this comment.
@ravjot07 thanks again for your contribution.
I have left a comment about supporting EUI-64 which should be easy to fix.
comid/measurement.go
Outdated
Comment on lines
464
to
469
| // Validate MAC Address | ||
| if o.MACAddr != nil { | ||
| if len(*o.MACAddr) != 6 { // MAC address must be exactly 6 bytes | ||
| return fmt.Errorf("invalid MAC address length: expected 6 bytes, got %d", len(*o.MACAddr)) | ||
| } | ||
| } |
There was a problem hiding this comment.
The CoRIM spec allows for {MAC,EUI}-48 as well as EUI-64 formatted MAC addresses:
mac-addr-type-choice = eui48-addr-type / eui64-addr-type
eui48-addr-type = bytes .size 6
eui64-addr-type = bytes .size 8
Therefore, 8 is acceptable too.
There was a problem hiding this comment.
@thomas-fossati i have updated MAC address validation to allow EUI-48 and EUI-64 formats
Signed-off-by: Ravjot Singh <[email protected]>
Signed-off-by: Ravjot Singh <[email protected]>
| @@ -26,7 +26,7 @@ var ( | |||
| }) | |||
| TestOID = "2.5.2.8192" | |||
| TestRegID = "https://acme.example" | |||
| TestMACaddr, _ = net.ParseMAC("02:00:5e:10:00:00:00:01") | |||
There was a problem hiding this comment.
Last thing, I promise ;-)
If you revert this, the diff is smaller since the change to comid/example_test.go becomes unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measurement.Validmethod, addressing the TODO comment: "MAC addr & friends."This PR close #18