command line interface #21

thomas-fossati · 2021-09-29T21:06:35Z

It's quite a lot to ingest, sorry. However, the PR is split into a number of (hopefully) logical commits that can be reviewed in isolation.

The docs (https://github.com/veraison/corim/blob/cli/cocli/README.md) might help getting a high level view of the whole thing before being bogged down into the minutiae.

If you are planning to install the CLI as per README.md instructions, note that the go install command needs to be slightly amended to point to the dev branch:

go install github.com/veraison/corim/cocli@9a8057cf37abd4a2aecfd4c328dee31fc9711b8f

(This PR is relevant in the context of ietf-rats/ietf-corim-cddl#121)

cocli/cmd/corimCreate.go

cocli/cmd/corimDisplay.go

yogeshbdeshpande · 2021-10-19T11:47:26Z

cocli/cmd/corimDisplay.go

+
+			if bytes.Equal(cborTag, corim.ComidTag) {
+				if err = printComid(cborData, hdr); err != nil {
+					fmt.Printf(">> skipping malformed CoMID tag at index %d: %v\n", i, err)


I understand you want to continue decoding at line 114, 118 and 121, but should they not be really fmt.Errorf("") considering that there is still an error in the system?

cocli/cmd/corimExtract.go

cocli/cmd/corimSign.go

cocli/cmd/corimVerify.go

yogeshbdeshpande · 2021-10-19T12:26:27Z

I have completed my review! Happy to discuss them in a short call, if any comment is un-clear!

thomas-fossati · 2021-10-19T15:21:25Z

e same level as the rest of the library code. I think we'd be introducing an artificial distinction with no added value.

That's precisely I am saying: As you mentioned yourself, it is a "serious tool"!

All I am saying that just like "Docs" go in docs folder (as they are documents), Examples go in examples folder, script goes in "script" folder, similarly there should be a suitable top level entity that precisely describe the job that this deliverable does!

As per discussion, we are dealing with this in #22

cocli/README.md

.github/workflows/ci-go-cover.yml

cocli/README.md

thomas-fossati · 2021-10-26T13:02:07Z

Fixes #19

thomas-fossati force-pushed the cli branch from d610f9d to 9817c26 Compare September 29, 2021 21:10

thomas-fossati changed the title ~~comid create~~ CLI (comid create) Sep 29, 2021

thomas-fossati force-pushed the cli branch 6 times, most recently from 62da24f to 417d148 Compare September 30, 2021 07:29

thomas-fossati changed the title ~~CLI (comid create)~~ command line interface Sep 30, 2021

CLI, "comid create" subcommand

3aa1c5f

thomas-fossati force-pushed the cli branch from e872442 to b5e306b Compare October 1, 2021 20:53

thomas-fossati added 3 commits October 5, 2021 18:22

CLI, "comid validate" subcommand

c8c45a7

add JSON encoders for Comid

f73a11a

CLI, "comid display" subcommand

31ee322

thomas-fossati force-pushed the cli branch 2 times, most recently from bb48fe2 to 3ff20db Compare October 5, 2021 20:27

CLI, "corim create" subcommand

24b9bc9

thomas-fossati force-pushed the cli branch 2 times, most recently from c1e3802 to d602d9a Compare October 6, 2021 14:27

CLI, "corim sign" subcommand

c491733

thomas-fossati force-pushed the cli branch from d602d9a to c491733 Compare October 6, 2021 14:30

thomas-fossati added 2 commits October 6, 2021 16:31

CLI, "corim verify" subcommand

d63262b

CLI, "corim display" subcommand

baa5611

thomas-fossati force-pushed the cli branch from aefab11 to baa5611 Compare October 7, 2021 10:32

thomas-fossati added 2 commits October 7, 2021 14:58

CLI, "corim extract" subcommand

9a1afe2

normalise / omogenise command line arguments

2e1cbfb

thomas-fossati self-assigned this Oct 7, 2021

add JSON marshaler to corim.Roles

8d3a095

thomas-fossati force-pushed the cli branch from e0163b1 to 8d3a095 Compare October 7, 2021 21:09

CLI docs: comid create

c65a3d9