Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make from_jwt public #3

Merged
merged 1 commit into from
Oct 19, 2023
Merged

make from_jwt public #3

merged 1 commit into from
Oct 19, 2023

Conversation

chendave
Copy link
Member

There is a case to use from_jwt with a DecodingKey directly

@chendave
Copy link
Member Author

/cc @setrofim

or is there any alternative?

Copy link
Contributor

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you fix the format checker error. Otherwise, looks good!

@chendave
Copy link
Member Author

Please could you fix the format checker error. Otherwise, looks good!

Done.

There is a case to use `from_jwt` with a `DecodingKey` directly

Signed-off-by: Dave Chen <[email protected]>
@chendave
Copy link
Member Author

if you don't mind, can you pls merge this one as well? @yogeshbdeshpande @thomas-fossati

@thomas-fossati thomas-fossati merged commit cc6ea53 into veraison:main Oct 19, 2023
4 checks passed
@chendave chendave deleted the public branch November 20, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants