Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add peer and optional deps #125

Closed
wants to merge 3 commits into from

Conversation

tknickman
Copy link
Member

@tknickman tknickman commented Jan 18, 2024

Add react as a peer to ensure that there are no transitive dependencies (so pnpm doesn't complain when using isolated modules).

Similar to vercel/speed-insights#45

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 11:42am
analytics-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 11:42am

Copy link

vercel bot commented Jan 18, 2024

@tknickman is attempting to deploy a commit to the Analytics Team on Vercel.

A member of the Team first needs to authorize it.

@feugy
Copy link
Member

feugy commented Feb 20, 2024

Thanks @tknickman.
We got it merged else where, and the final state is in line with your proposal. :same-brain:

@feugy feugy closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants