-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental flag from serverActions.bodySizeLimit
#57661
Remove experimental flag from serverActions.bodySizeLimit
#57661
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @styfle, @huozhi:
|
@@ -140,16 +140,14 @@ In both cases, the form is interactive before hydration occurs. Although Server | |||
|
|||
## Size Limitation | |||
|
|||
By default, the maximum size of the request body sent to a Server Action is 1MB, to prevent the consumption of excessive server resources in parsing large amounts of data. | |||
By default, the maximum size of the request body sent to a Server Action is `1mb`, to prevent the consumption of excessive server resources in parsing large amounts of data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serverActionsBodySizeLimit ?? '1mb' |
Seems like #57529 is adding more options, need to resolve any conflicts if needed. |
@devjiwonchoi Thanks for the PR, we still plan it as experimental flags, we removed |
@huozhi I just wanna know that this: module.exports = {
experimental: {
serverActions: {
bodySizeLimit: '1mb',
},
},
} is resulting console as:
and does it not need any modification at the moment? |
@devjiwonchoi that sounds like an issue for configuration validation, thanks for reporting, we'll take a look on that! |
Want to also add that even if Server Actions are considered stable, some options to tweak its behavior might still remain experimental (such as the body size thing). Mostly because they were introduced as a work around to certain issues that might be fixed in a different way in the future. |
Since the Server Actions became stable, the following config for
bodySizeLimit
should also be removed from theexperimental
section.This PR added the
serverActions
option to the next config for the currentbodySizeLimit
and further additions.Also, modified text on docs from
bytes
tobits
andMB
tomb
.Extends #57145 #57433